Deduplicate and reorganize specs for Kernel#raise #1332
+74
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinistr
force-pushed
the
improve-kernel-raise
branch
from
8d4fdf6 to
1e957b6
Compare
| cause = StandardError.new | ||
| -> { raise("error", cause: cause) }.should raise_error(RuntimeError) { |e| e.cause.should == cause } | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
minor: haven't found a similar test in :kernel_raise_with_cause. Isn't it just being deleted?
Contributor
Author
There was a problem hiding this comment.
Seems I had code blindness when reviewing changes. I've added tests for this and the next one. Also added a context "without cause keyword argument", which now houses tests for what happens when cause is not specified.
|
|
||
| it "doesn't raise a TypeError when given cause is nil" do | ||
| -> { raise "message", cause: nil }.should raise_error(RuntimeError, "message") | ||
| end |
| raise | ||
| end | ||
| end.should raise_error(StandardError, "aaa") | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This one is covered by existing https://github.com/ruby/spec/pull/1332/changes#diff-866cdb19d113cd7e3798855d9e2bc74a30e2307efae414383ee88629580d80a5R20-R39
- Include shared spec which has better descriptions and more tests. - Test Kernel#raise, not Kernel.raise (Kernel.raise has separate tests). - Remove duplicated tests. There is more work to be done in organizing the tests: - Fiber and Thread seem to have some generic tests that are already included in the shared spec. - Tests for intricacies of re-raising exceptions could also be moved to the shared spec probably.
trinistr
force-pushed
the
improve-kernel-raise
branch
from
1e957b6 to
de25fdd
Compare
Contributor
Author
|
How did a test that doesn't exist on this branch fail on an Encoding that doesn't exist in Ruby? 😅 |
Member
|
^ discussed in #1330 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more work to be done in organizing the tests: